refactor(express): split pingExpress into v1 and v2#8563
Open
rishikeshdadam136 wants to merge 1 commit intomasterfrom
Open
refactor(express): split pingExpress into v1 and v2#8563rishikeshdadam136 wants to merge 1 commit intomasterfrom
rishikeshdadam136 wants to merge 1 commit intomasterfrom
Conversation
rishikeshdadam136
changed the title
rishikeshdadam136
force-pushed
the
WCI-188
branch
from
37d34ec to
bf896ac
Compare
rishikeshdadam136
changed the title
rishikeshdadam136
force-pushed
the
WCI-188
branch
from
bf896ac to
9e50234
Compare
rishikeshdadam136
requested a deployment
to
breaking-changes-override
GitHub Actions
Waiting
mrdanish26
requested changes
Apr 24, 2026
| } | ||
|
|
||
| function handlePingExpress(req: ExpressApiRouteRequest<'express.pingExpress', 'get'>) { | ||
| function handlePingExpress(req: ExpressApiRouteRequest<'express.pingexpress', 'get'>) { |
Contributor
There was a problem hiding this comment.
handlePingExpress is wired to both express.v1.pingexpress and express.pingexpress, but the parameter type only mentions express.pingexpress. Update to ExpressApiRouteRequest<'express.v1.pingexpress' | 'express.pingexpress', 'get'> so the type matches both registrations.
| // V2 routes should be added to www/config/routesV2.js | ||
|
|
||
| // ping | ||
| // /api/v[12]/pingexpress is the only exception to the rule above, as it explicitly checks the health of the |
Contributor
There was a problem hiding this comment.
Update comments so it matches the split
Contributor
There was a problem hiding this comment.
Add a minimal test that both GET /api/v1/pingexpress and GET /api/v2/pingexpress resolve and return the expected payload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: WCI-188
Context - https://bitgo.slack.com/archives/C057BHBRG4B/p1764020095794829?thread_ts=1764018507.602879&cid=C057BHBRG4B
The API behavior is not changing. We are splitting the combined v[12] route into two separate V1 and V2 routes, so both will continue to work and clients will not be affected.